dolthub/dolt#1374 - feat(commit): distinguish between commit author and committer #9640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for distinguishing between commit author (who wrote the changes) and committer (who created the commit), matching Git's commit metadata model. This allows for better attribution in scenarios like rebasing, cherry-picking, and applying patches. BREAKING CHANGE: CommitMeta struct now uses AuthorName/AuthorEmail instead of Name/Email. The old fields are deprecated but maintained for backward compatibility. Commits will be written in a new v2.0 format that includes both author and committer information. - Add new CommitMeta fields: AuthorName, AuthorEmail, AuthorDate, CommitterName, CommitterEmail, CommitterDate - Update Flatbuffer schema with new author/committer fields - Add CLI flags: --committer and --committer-date - Update DOLT_COMMIT SQL procedure to accept committer parameters - Add new columns to dolt_commits and dolt_log system tables - Support DOLT_AUTHOR_DATE and DOLT_COMMITTER_DATE environment variables - Maintain full backward compatibility for reading/writing old format commits - Update all display functions to use new author fields The implementation ensures that: - Old Dolt clients can read new commits (using deprecated fields) - New Dolt clients can read old commits (copying to both author/committer) - Default behavior unchanged when committer info not specified Refs: dolthub#1374
Tests cover CLI flags, environment variables, SQL integration, backward compatibility, and error handling. Includes 14 test cases verifying: - --author and --committer flag behavior - DOLT_AUTHOR_DATE and DOLT_COMMITTER_DATE env vars - SQL stored procedure integration - Database schema changes (dolt_commits table) - Backward compatibility with existing columns - Default behavior and error conditions Refs: dolthub#1374
codeaucafe
changed the title
codeaucafe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements GitHub issue #1374, adding support for distinguishing between commit author (who wrote the changes) and committer (who created the commit), matching
Git's commit metadata model. This enables better attribution in scenarios like rebasing, cherry-picking, and applying patches.
Key Changes
Core Implementation (28a7d9b)
Data Structure Updates:
CLI Enhancements:
Environment Variable Support:
SQL Integration:
Backward Compatibility:
Test Coverage (5ed518f)
Comprehensive BATS Test Suite:
Default Behavior
When committer info is not specified:
When only partial info is provided:
Refs: #1374