decompose tuple inequalities#3575
Merged
Merged
Conversation
nicktobey
reviewed
Jun 4, 2026
|
|
||
| leftTuple, ok := left.(expression.Tuple) | ||
| if !ok { | ||
| // TODO: if len(leftTuple) == 0 or len(rightTuple) == 0, just return false? |
Contributor
There was a problem hiding this comment.
"just return false" as in replace the expression with false? I don't think we can do that. For example, () = () would be true. But I also imagine that zero-length tuples will end up being handled correctly by the individual cases.
| switch e := e.(type) { | ||
| case *expression.InTuple, *expression.HashInTuple: | ||
| newExpr, ok = c.transformInTupleForIndexCosting(leftTuple, rightTuple) | ||
| case *expression.Equals: // TODO: *expression.NullSafeEquals? |
Contributor
There was a problem hiding this comment.
This probably shouldn't be a TODO.
Experimenting with MySQL, it seems that a normal tuple comparison is equivalent to normal comparing each element, and null safe tuple comparison is equivalent to null-safe comparing each element.
Dolt appears to get this wrong: dolthub/dolt#11024
nicktobey
approved these changes
Jun 4, 2026
nicktobey
requested changes
Jun 4, 2026
|
|
||
| leftTuple, ok := left.(expression.Tuple) | ||
| if !ok { | ||
| // TODO: if len(leftTuple) == 0 or len(rightTuple) == 0, just return false? |
added 2 commits
June 4, 2026 12:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the tuple in filter decomposition logic to cover tuples in equallities and inequalities.