Add clarifying example in migration guide to v10 #3672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a concrete example on how to check for concrete types in order to mutate model properties in the migration guide. Without the example, I personally read over the bullet point in the migration guide. It might or might not be helpful for others, if you don't think so please feel free to ignore the PR.
martincostello
approved these changes
Nov 23, 2025
Collaborator
martincostello
left a comment
martincostello
left a comment
There was a problem hiding this comment.
Thanks, just a few copy-edits.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3672 +/- ##
=======================================
Coverage 94.53% 94.53%
=======================================
Files 111 111
Lines 3861 3861
Branches 778 778
=======================================
Hits 3650 3650
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a concrete example on how to check for concrete types in order to mutate model properties in the migration guide. Without the example, I personally read over the bullet point in the migration guide.
It might or might not be helpful for others, if you don't think so please feel free to ignore the PR.