This repository was archived by the owner on Dec 4, 2018. It is now read-only.
Open
Conversation
|
Any chance of this PR getting merged? And should the console.log rather use a logger, so it won't output unless a logger is defined for debugging or other usage? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library checks
!module.parentto determine whether it is running as a script. When used in the create-react-app webpack environment,module.parentis not set as expected, either viaimportorrequire. The lack of value formodule.parentcauses spurious logging to the console in these React apps.Per the official Node module docs, we should be checking
require.main === moduleinstead. This pull request does just that. With this change, the spurious console logs disappear.