-
Notifications
You must be signed in to change notification settings - Fork 6
QE-18127 add debug logging for browser steps #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
QE-18127 add debug logging for browser steps #642
Conversation
ddl-cedricyoung
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I think this ticket requires a little more comprehensive approach. There is a lot of methods in this file
browser_steps.pythat don't have logging. - Also I think we're missing logging at a higher level, that is in the set method for
config.CONFIG[variable] = - And we should update tests to ensure this logging continues to work.
|
@ddl-cedricyoung If we add logging at
@ddl-cedricyoung if we add logging at higher level in the set method, it will log all the config values useful(port,host_address, scenario metadata, hooks, timeouts, browser info) and sensitive(credentials, tokens, API keys, cookies, headers, 2FA secrets). Even if we just capture just useful information it's too much noise in the report. |
@ddl-kavya did you try it? I'm assuming that the secret scrubbing already scrubs out the sensitive info, but I might be mistaken. |
|
@ddl-cedricyoung Yes, I tried it in my local and it is not scrubbing the sensitive information.
|

PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: https://dominodatalab.atlassian.net/browse/QE-18127
What is the new behavior?
Does this PR introduce a breaking change?
Other information