Skip to content

[DOM-65232] Fix tests failing in main and Implement range download for datasets over datasources #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

ddl-mcetin
Copy link
Collaborator

@ddl-mcetin ddl-mcetin commented Mar 31, 2025

Description

  • Refactors and fixes about 10 failing tests in main
  • Implements range download for Datasets read api

Related Issue

https://dominodatalab.atlassian.net/browse/DOM-65232
DOM-65232

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

Copy link

github-actions bot commented Mar 31, 2025

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.21-final-0 -----------

Name Stmts Miss Cover
domino_data/init.py 7 2 71%
domino_data/_feature_store/init.py 0 0 100%
domino_data/_feature_store/client.py 43 22 49%
domino_data/_feature_store/exceptions.py 9 2 78%
domino_data/_feature_store/git.py 43 1 98%
domino_data/_feature_store/logging.py 7 0 100%
domino_data/_feature_store/run.py 16 16 0%
domino_data/_feature_store/sync.py 98 64 35%
domino_data/auth.py 109 30 72%
domino_data/configuration_gen.py 239 0 100%
domino_data/data_sources.py 292 60 79%
domino_data/datasets.py 141 32 77%
domino_data/logging.py 10 0 100%
domino_data/meta.py 22 0 100%
domino_data/training_sets/init.py 0 0 100%
domino_data/training_sets/client.py 135 10 93%
domino_data/training_sets/model.py 42 0 100%
domino_data/transfer.py 120 19 84%
domino_data/vectordb.py 23 4 83%
TOTAL 1356 262 81%
================== 90 passed, 1

@ddl-mcetin ddl-mcetin changed the title Fix tests failing in main and Implement range download for datasets over datasources [DOM-65232] Fix tests failing in main and Implement range download for datasets over datasources Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant