Skip to content

Conversation

@hz-xiaxz
Copy link

Disclaimer: I'm in no way familiar with JuliaSyntax, just play with Gemini and try to make it not error.
related to #901 #928
No error on the kinds part now, I fixed the lost API of core_@cmd (macro is now parsed to a tree), false (this is Bool now), cartesian_iteration (maybe it's iteraction now? JuliaLang/JuliaSyntax.jl#432)

changed deprecated has_children to !is_leaf.

I would admit I don't fully understand the change, but I hope it would be a good starting point?

@hz-xiaxz
Copy link
Author

tons of test not passed, I can't fix it myself.
For a cleaner diff, maybe revert the a218a99 locally?

@hz-xiaxz
Copy link
Author

Also I hadn't edited the pretty.jl in YAS and SciML, so they are supposed to error..

@domluna
Copy link
Owner

domluna commented Jul 19, 2025

the main problem with v1 is that it's changed how operators are treated. they are now all identifiers. the formatter relied heavily on them being tagged as operators and being able to determine the type of operator so a more involved solution is required that would take some time to figure out.

edit: v2 will also be tagged at some point relatively soon which might also have further breaking changes.

@oscardssmith
Copy link
Contributor

It is worth getting 1.0 support as 2.0 is an intermediary in terms of what changes. Also JuliaSyntax 1.x is likely to be used by Julia 1.10-1.12 for a while. IIUC JuliaSyntax 2.0 is for Julia 1.13+ with JuliaLowering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants