-
Notifications
You must be signed in to change notification settings - Fork 79
Try to compat JuliaSyntax v1.0 #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… iteration now
|
tons of test not passed, I can't fix it myself. |
|
Also I hadn't edited the pretty.jl in YAS and SciML, so they are supposed to error.. |
|
the main problem with v1 is that it's changed how operators are treated. they are now all identifiers. the formatter relied heavily on them being tagged as operators and being able to determine the type of operator so a more involved solution is required that would take some time to figure out. edit: v2 will also be tagged at some point relatively soon which might also have further breaking changes. |
|
It is worth getting 1.0 support as 2.0 is an intermediary in terms of what changes. Also JuliaSyntax 1.x is likely to be used by Julia 1.10-1.12 for a while. IIUC JuliaSyntax 2.0 is for Julia 1.13+ with JuliaLowering. |
Disclaimer: I'm in no way familiar with JuliaSyntax, just play with Gemini and try to make it not error.
related to #901 #928
No error on the kinds part now, I fixed the lost API of
core_@cmd(macro is now parsed to a tree),false(this isBoolnow),cartesian_iteration(maybe it'siteractionnow? JuliaLang/JuliaSyntax.jl#432)changed deprecated
has_childrento!is_leaf.I would admit I don't fully understand the change, but I hope it would be a good starting point?