Octogonz/add peer deps - #1
Open
octogonz wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix errors printed by the ESLint extension for VS Code:
my-app's .eslintrc.json said"extends": ["react-app"]which is an undeclared dependency on theeslint-config-react-apppackage (called a "phantom dependency"). I replaced the .eslintrc.json shorthand with the fully qualified name to make this more obvious."eslint-config-react-app"to your package.json file.eslint-config-react-apphas a bunch of peer dependencies on other ESLint packages. They are declared as peers because of a longstanding issue where ESLint looks for dependencies in themy-appfolder instead of in theeslint-config-react-appfolder.These issues all reflect that
create-react-appis designed for starter projects and assumes that you are using NPM's installation model.