Add support for reading TMN ESWC replays #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donadigo
requested changes
Jun 22, 2021
average_steer_partitions.py
Outdated
| val >>= int32(8) | ||
| return -val | ||
|
|
||
| def clean_duplicate_events(events: list): |
Owner
There was a problem hiding this comment.
Please annotate that this also returns list.
average_steer_partitions.py
Outdated
| """ | ||
| events_cleaned = [] | ||
| for i in range(0, (len(events)-1)): | ||
| if int(events[i+1].time / 10) * 10 != int(events[i].time / 10) * 10: |
Owner
There was a problem hiding this comment.
What happens when there's events like this?
10000 Accelerate (1)
10000 Brake (1)
10010 Accelerate (0)
Is the first accelerate simply skipped?
Author
There was a problem hiding this comment.
Very good point. Reworked the function to skip over everything that is not a Steer event
generate_input_file.py
Outdated
| val >>= int32(8) | ||
| return -val | ||
|
|
||
| def clean_duplicate_events(events: list): |
- Only clean steer events and leave other events completely untouched - round up time to next 10 instead of midway rounding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on this change donadigo/pygbx#11 in pygbx.