Added wrap-around styling for demo name in export to excel window #1263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for when the browser is too narrow
dondi
reviewed
Nov 5, 2025
Owner
dondi
left a comment
dondi
left a comment
There was a problem hiding this comment.
Code looks good but we have some UA feedback that we can address here
|
|
||
| .export-radio-group li | ||
| display: flex; | ||
| align-items: center; |
Owner
There was a problem hiding this comment.
Per UA (user acceptance) feedback, let’s change this to align-items: flex-start
Suggested change
| align-items: center; | |
| align-items: flex-start; |
This change usually has a side-effect where the radio will then look off when the item is just one line, so…
| margin-bottom: 8px; | ||
|
|
||
| .export-radio | ||
| margin-top: 3px; |
Owner
There was a problem hiding this comment.
…maybe not here, but potentially somewhere else, usually when we have top-alignment, one or more items will need margin-top adjustments so that they appear to be centered when the items are short enough for one line
merging beta into remote branch :wq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think there's an official issue/ticket for this but I remember during our last meeting that Dr. Dhalquist mentioning wanting to fix how the demo name starts below the select button (in the export to excel pop-up) when the browser gets too narrow. I added wrap styling for when the browser is too narrow - see attached screenshot for what it looked like before vs now. If we want it to look differently I can change that as well but this is what I came up with!