Improve edit UI and priority colors - #1177
Merged
dongdongbh merged 7 commits intoSep 6, 2026
Merged
Conversation
…top and mobile and add a feature-gated Priority… action to the task quick menu, centralizing the fixed ramp in core so row strips, editor pills, slash commands, filters, inbox processing and quick capture share one affordance
…turn Preview/Edit, change-time, clear and attachment row actions into labelled icon buttons, and align attachment and checklist button styling
…urn change-time, clear, preview, edit and attachment actions into labelled icon buttons, make None controls icon-only, and align attachment and Add Item button styling
…None and swap the change-time chip for a labelled clock icon button
14 tasks
…ity colours from core everywhere, swap the last text glyphs for lucide icons and stub every lucide icon in tests (dongdongbh#1172)
dongdongbh
approved these changes
Sep 6, 2026
dongdongbh
left a comment
Owner
There was a problem hiding this comment.
Ready to merge
Good work, this lands the whole of #1172 and the Priority quick action fits the other quick actions well, so it stays.
I pushed one commit on top of your branch (95fe85c) rather than asking for another round:
- The mobile editor header shows the word Save again. The X on the left is fine, but a first-time user needs to see which control commits the draft, so Save keeps its text. The header test now asserts that.
- The mobile widget now reads
TASK_PRIORITY_COLORSfrom core andapps/mobile/lib/priority-colors.tsis gone, so there is one priority ramp for the app and the widget. The unused import inSwipeableTaskItemContent.tsxwent with it. - The lucide mock in
apps/mobile/vitest.setup.tsnow stubs any icon name instead of an allowlist.Navigationand about fifteen older imports were missing from the list, and the first test to render one of those fields would have failed far from the change. - The last text glyphs on the lines you touched are lucide icons now: the sparkle on the desktop "Create project" option, the plus on the mobile Add item and picker create rows, and the check marks in the quick capture pickers.
Owner
Ready to mergeGood work, this lands the whole of #1172 and the Priority quick action fits the other quick actions well, so it stays. I pushed one commit on top of your branch (95fe85c) rather than asking for another round:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves task-editor clarity with consistent vector icons, colored priority flags, labelled icon-only controls, and cleaner energy labels across desktop and mobile. Adds a mobile close control wired through the existing unsaved-changes flow while preserving Save behavior and accessibility labels.
Related issue
Closes #1172
Testing
Full mobile & desktop test suite.
Screenshots / recordings
Checklist