Authorization #34
Open
Authorization #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongiveajack
commented
May 19, 2025
| @FeignClient(name = "realm", url = "${realm.base-url}") | ||
| public interface RealmClient { | ||
| @RequestMapping(method = RequestMethod.POST, value = "/sessioninfo/authorize") | ||
| RealmSessionInfoResponse getSessionInfo(@RequestHeader("Cookie") String cookie, @RequestBody RealmAuthenticateRequest request); |
There was a problem hiding this comment.
will remove this redundant client call
dagaranupam
reviewed
May 19, 2025
| @FeignClientAdvice(RealmExceptionHandler.class) | ||
| @FeignClient(name = "realm", url = "${realm.base-url}") | ||
| public interface RealmClient { | ||
| @RequestMapping(method = RequestMethod.POST, value = "/sessioninfo/authorize") |
There was a problem hiding this comment.
duplicate api definition. same as authorize present below
dagaranupam
approved these changes
May 19, 2025
Replaced exact URI matching with pattern-based matching using AntPathMatcher. This allows for more flexible and efficient identification of allowed permissions based on API patterns. Added a new helper method to handle pattern matching logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added support for authorization