test: add thorough tests for streaming decoding #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
approved these changes
Jan 8, 2026
Comment on lines
+88
to
+99
| test('zstddec-stream: decode without init should throw error', async (t) => { | ||
| const zstd = new ZSTDDecoder(); | ||
|
|
||
| try { | ||
| zstd.decode(HELLO_WORLD_ZSTD); | ||
| // If we get here, the implementation doesn't throw - test behavior as-is | ||
| t.pass('decode works without explicit init (auto-initializes or uses shared instance)'); | ||
| } catch (err) { | ||
| t.ok(err.message.includes('Await .init() before decoding'), 'throws error when decode called before init'); | ||
| } | ||
| t.end(); | ||
| }); |
Owner
There was a problem hiding this comment.
Not blocking but I don't think I understand this case - shouldn't this consistently either throw, or not?
Contributor
Author
There was a problem hiding this comment.
No, we have a global init promise, which, if not settled, raises an exception. Which is kind of hard to test.
donmccurdy
reviewed
Jan 8, 2026
| } catch (err) { | ||
| // If it throws, that's also acceptable behavior | ||
| t.ok(err.message.includes('Incomplete stream') || err.message.length > 0, 'throws error for incomplete stream with no data'); | ||
| } |
Owner
There was a problem hiding this comment.
Similarly, I think I may change this to enforce one behavior or the other. Not that I have a strong preference, but would like to know if the behavior changed, and the test can ensure that. Unless there was some reason to include both?
Contributor
Author
There was a problem hiding this comment.
Hmm, good question, I agree, we should only include the first, I think
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.