Open
Conversation
TODO: Proper keymaps and indices
TODO: Add proper height for "plus" and "enter" keys.
Open
andyrak
changed the title
|
@donn hey, hope you're doing well. Just curious when this PR will be merged? |
Owner
|
Hi @toineenzo -- this PR is still open so the patchset is still there when I need it. Getting Halo96 working from this point (which, for the record, SUPER appreciated) would take a more considerable amount of time (and testing.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Going off of what exists for the Halo75, this PR adds basic support for Halo96 detection.
Made some UI tweaks to handle the double-height keys on the Halo96, namely the plus and enter keys on the numpad. Also prettified the arrow keys using ↑↓←→.
Keyboard detection seems to be working properly with as-is values, but
getKeymapReportHeaderandsetKeymapReportHeaderhave been marked as TODO, and keymaps and indices are still unknown. Will need some assistance from @donn with the dumps he has to further development.Screenshot of UI included below.