Add support for discussions to digests #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dontcallmedom
force-pushed
the
support-discussions
branch
2 times, most recently
from
e1ec0fd to
5f68022
Compare
dontcallmedom
force-pushed
the
support-discussions
branch
from
5f68022 to
febee27
Compare
dontcallmedom
commented
Aug 26, 2025
tidoust
requested changes
Aug 27, 2025
Collaborator
tidoust
left a comment
tidoust
left a comment
There was a problem hiding this comment.
On top of better support for recent comments, it would be great to start with new discussions, then to list discussions that received new comments.
| disc_comments = { | ||
| "discussion": disc_data, | ||
| "comments": comments, | ||
| "commentscount": discussion.get("comments", {}).get("totalCount", len(comments)), |
Collaborator
There was a problem hiding this comment.
Suggested change
| "commentscount": discussion.get("comments", {}).get("totalCount", len(comments)), | |
| "commentscount": comments.get("totalCount", len(comments)), |
| }} | ||
| createdAt | ||
| updatedAt | ||
| comments(first: 10) {{ |
Collaborator
There was a problem hiding this comment.
No pagination might be fine, but comments should probably be ordered by descending updated date to get new comments instead of always the first 10 ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #67