-
Notifications
You must be signed in to change notification settings - Fork 9
download-fileset: improve _find_matching_artifact for git revision
#114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f40419d to
fcbed80
Compare
fcbed80 to
a7948c9
Compare
Contributor
|
Not sure how much of a problem it is but download command fails when not admin |
47c4c43 to
4dabaaf
Compare
ftith
approved these changes
Apr 24, 2025
|
|
||
| subprocess.check_call(['git', 'remote', 'add', 'origin', remote], cwd=tmp_git_dir) | ||
|
|
||
| # if current workdir contains a git repo, use it as alternate to prevent unnecessary burden on remote |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
4dabaaf to
727c825
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code rely a lot on the Giteapy package to query our Gitea instance's API to retrieve commit order used to define which artifact is the newest.
Giteapy instantiation here check for a "gitea env" with check_for_gitea_env, which itself look if current
env.branchis in a manually maintained listproject_branchesin the project.nimp.conf.On a new branch, CI jobs fail with
[ERROR] Revision seems to be a git commit hash but missing gitea api information. Please check project_branches in project configuration.A quick fix would be to add the branch to the configuration branches, but it's better to remove this unnecessary limitation altogether.
This also add:
--revisionand--max-revisioncases.