Skip to content

Prepare xpj conf for using .nimp.conf instead of baseNimp.conf #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Prepare xpj conf for using .nimp.conf instead of baseNimp.conf #22

wants to merge 1 commit into from

Conversation

@jasugun
Copy link
Contributor

@jasugun jasugun commented Nov 23, 2021

Rework how we load nimp conf files:

  • Set is_unreal if .nimp conf file is detected in unreal base path
  • Load legacy generic nimp conf first (if no unreal detected, or unreal <= 4.24)
  • Load monorepo conf if monorepo unreal is detected
  • Monorepo conf consists of base xpj .nimp.conf, overridable by specific uproject conf
  • Temporarily maintain deprecated xpj .baseNimp.conf (so we have time to replace them by .nimp.conf files)

@tdesveaux tdesveaux self-requested a review November 24, 2021 12:05
samhocevar
samhocevar approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@samhocevar samhocevar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me.

@tdesveaux tdesveaux removed their request for review November 25, 2021 09:06
@jasugun jasugun requested review from ftith and tdesveaux November 8, 2022 10:37
@tdesveaux tdesveaux deleted the branch main April 4, 2025 09:12
@tdesveaux tdesveaux closed this Apr 4, 2025
@tdesveaux
Copy link
Contributor

tdesveaux commented Apr 4, 2025

Wrongly closed by dev branch deletion

@tdesveaux tdesveaux reopened this Apr 4, 2025
@tdesveaux tdesveaux changed the base branch from dev to main April 4, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samhocevar samhocevar samhocevar approved these changes

@tdesveaux tdesveaux Awaiting requested review from tdesveaux

@ftith ftith Awaiting requested review from ftith

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasugun @tdesveaux @samhocevar