Skip to content

Add verbosity to P4 Submit command #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add verbosity to P4 Submit command #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3057cd
utils p4: Add verbose argument
Aug 30, 2022
93d8aae
base_commands: p4 submit forward verbose arg
Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nimp/base_commands/p4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,4 +178,4 @@ def run(self, env):
description = env.format(env.changelist_description)
changelist = p4.get_or_create_changelist(description)

return p4.submit(changelist)
return p4.submit(changelist, verbose=env.verbose)
7 changes: 5 additions & 2 deletions nimp/utils/p4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,13 @@ def revert_unchanged(self, cl_number):
output = self._run('revert', '-a', '-c', cl_number, '//...')
return output is not None

def submit(self, cl_number):
def submit(self, cl_number, verbose=False):
'''Submits given changelist'''
logging.info("Submiting changelist %s...", cl_number)
command = self._get_p4_command('submit', '-f', 'revertunchanged', '-c', cl_number)
args = ['submit', '-f', 'revertunchanged', '-c', cl_number]
if verbose:
args.insert(0, '-I')
command = self._get_p4_command(*args)
_, _, error = nimp.sys.process.call(command, capture_output=True)

if error is not None and error != "":
Expand Down