feat: enable sync scroll by default#1571
Merged
Merged
Conversation
- Change enableScrollSync default from false to true in ui store chore: upgrade dependencies - @cloudflare/workers-types: 4.20260523.1 -> 4.20260524.1
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the web app’s default UI behavior to enable synchronized scrolling between the editor and preview out of the box, and bumps Cloudflare Workers type definitions used for the Workers build/deploy tooling.
Changes:
- Set
enableScrollSyncdefault fromfalsetotruein the UI Pinia store. - Upgrade
@cloudflare/workers-typesto4.20260524.1inapps/web. - Regenerate
pnpm-lock.yamlto reflect the dependency update (and related resolution changes).
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apps/web/src/stores/ui.ts |
Changes the persisted default for scroll sync to enabled. |
apps/web/package.json |
Bumps @cloudflare/workers-types devDependency version range. |
pnpm-lock.yaml |
Updates lockfile entries for @cloudflare/workers-types and related dependency resolution. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comment on lines
10104
to
10108
| '@typescript-eslint/project-service@8.59.3(typescript@6.0.3)': | ||
| dependencies: | ||
| '@typescript-eslint/tsconfig-utils': 8.59.3(typescript@6.0.3) | ||
| '@typescript-eslint/types': 8.59.3 | ||
| '@typescript-eslint/tsconfig-utils': 8.59.4(typescript@6.0.3) | ||
| '@typescript-eslint/types': 8.59.4 | ||
| debug: 4.4.3(supports-color@5.5.0) |
|
🚀 Cloudflare Workers Preview has been successfully deployed! Preview URL: https://md-pr-1571.doocs.workers.dev Built with commit 40d2c07 |
|
🚀 Surge Preview has been successfully deployed! Preview URL: https://doocs-md-preview-pr-1571.surge.sh Built with commit 40d2c07 |
|
🗑️ Cloudflare Workers preview deployment has been cleaned up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
enableScrollSyncdefault:false->true)@cloudflare/workers-types:4.20260523.1->4.20260524.1