Avoid duplicate Swift symbols from apple-cf - #159
Merged
Conversation
Contributor
Author
|
Hey @1313 again 😄 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered duplicate-symbol linker warnings while using
screencapturekitwithapple-cfafter update on latest Rust 1.97.Both crates build a Swift target named
CoreMediaBridgeand defineAudioBufferBridgeandAudioBufferListRaw. When a downstream binary pulls in both object files, their Swift metadata symbols collide. Rust 1.97 now exposes this linker output by default.This PR renames screencapturekit's private target to
ScreenCaptureKitCoreMediaBridge, giving it a distinct Swift module namespace. The source path and all@_cdeclexports remain unchanged, so there is no Rust or C API change.The second commit removes three redundant borrows reported by Rust 1.97 Clippy so the existing all-target CI check remains clean.
Used gpt5.6 sol model for it, but I keep only small changes to fix old bug and lint for latest Rust.