Add support for Zipper.find_all/3 - #163
Merged
Merged
Conversation
bcardarella
commented
Aug 10, 2024
| |> Z.next() | ||
| |> Z.next() | ||
| |> Z.next() | ||
| |> Z.next() |
Contributor
Author
There was a problem hiding this comment.
if there is a better way to get to the last node let me know. I tried Zipper.rightmost but I think that only goes to the right most of the current node
Contributor
Author
|
FYI unrelated tests failing with Elixir 1.17 |
bcardarella
force-pushed
the
bc-zipper-find-all
branch
from
August 10, 2024 00:32
94acb03 to
d70c6d9
Compare
Contributor
Author
|
force pushed format fix for CI |
doorgan
approved these changes
Aug 10, 2024
Owner
There was a problem hiding this comment.
Looks great, thank you!
About the 1.17 test issues, it seems some bugs in the elixir parser were fixed in core elixir. We can either backport those fixes in a new PR, or adopt lib_elixir(I have a POC here but there's some polishing needed to make it work appropriately)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.