Skip to content

Comment positioning seems dependent on line number information #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zachdaniel wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Comment positioning seems dependent on line number information #175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions test/sourceror_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,107 @@ defmodule SourcerorTest do
"""
|> String.trim()
end

test "comments do not depend on line numbers" do
ast1 =
{:__block__, [],
[
{:import,
[
trailing_comments: [],
leading_comments: [],
end_of_expression: [newlines: 0, line: 0, column: 0],
line: 0,
column: 0
],
[
{:__aliases__,
[
trailing_comments: [],
leading_comments: [],
last: [line: 0, column: 0],
line: 0,
column: 0
], [:Config]}
]},
{:config,
[
leading_comments: [
%{
line: 1,
text: "# Configures the foobar to",
column: 0,
next_eol_count: 0,
previous_eol_count: 1
},
%{
line: 1,
text: "# accomplish the barbaz",
column: 0,
next_eol_count: 0,
previous_eol_count: 1
}
],
trailing_comments: []
# line: 0 <- this is whats missing
],
[
:foo,
:bar
]}
]}

ast2 =
{:__block__, [],
[
{:import,
[
trailing_comments: [],
leading_comments: [],
end_of_expression: [newlines: 0, line: 0, column: 0],
line: 0,
column: 0
],
[
{:__aliases__,
[
trailing_comments: [],
leading_comments: [],
last: [line: 0, column: 0],
line: 0,
column: 0
], [:Config]}
]},
{:config,
[
trailing_comments: [],
leading_comments: [
%{
line: 0,
text: "# Configures the foobar to",
column: 0,
next_eol_count: 1,
previous_eol_count: 1
},
%{
line: 0,
text: "# accomplish the barbaz",
column: 0,
next_eol_count: 1,
previous_eol_count: 1
}
],
line: 0,
column: 0
],
[
:foo,
:bar
]}
]}

assert Sourceror.to_string(ast1) == Sourceror.to_string(ast2)
end
end

describe "patch_string/2" do
Expand Down