mock document fixes #704
Merged
mock document fixes #704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In MarkdownPublisher.create_index(), the top-level header line was getting overwritten by second call of write_text(), which always writes whole file rather than appending. Also add more mocks to testcase test_index_tree() so that it will show a document tree (instead of MagicMock placeholders with id numbers that change on every run of the test)
* fixes one mypy error: Unsupported operand types for + ("str" and "None")
Signed-off-by: Stephen L Arnold <[email protected]>
Signed-off-by: Stephen L Arnold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #703 and includes a minor mypy fix for None vs string. Thanks!