Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Oct 31, 2025

  • Explore repository structure and understand current oidc-client usage
  • Test current build and identify all files importing oidc-client
  • Update package.json to replace oidc-client with oidc-client-ts
  • Update OidcContext.svelte to use oidc-client-ts imports
  • Update rollup.config.js to use @rollup/plugin-node-resolve for proper ESM support
  • Update rollup.config.showcase.js to use @rollup/plugin-node-resolve
  • Test build after changes
  • Test showcase build
  • Run code review and address feedback
  • Check for security vulnerabilities in new dependency
  • Run CodeQL security scan
  • Rebase on next branch
  • Resolve merge conflicts
  • Verify builds after rebase
  • Finalize the migration

Rebase Summary

Successfully rebased on the next branch. The next branch already contained the rollup plugin updates (from commit 3454ba0), so the conflicts were resolved by:

  • Keeping the updated svelte compiler options from next
  • Merging the oidc-client-ts import changes
  • Adding the necessary ESM module resolution configurations
  • Regenerating package-lock.json

Both library and showcase builds pass successfully.

Original prompt

This section details on the original issue you should resolve

<issue_title>refactor: replace oidc-client with oidc-client-ts</issue_title>
<issue_description>oidc-client is archived and no longer receiving updates. the project needs to update to oidc-client-ts project which is a port of oidc-client to typescript and is still actively maintained. </issue_description>

<agent_instructions>Make the minimal changes necessary to switch to the new library. Maintain organized imports and code style in line with the surrounding context or any changes.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Refactor to replace oidc-client with oidc-client-ts refactor: migrate from archived oidc-client to oidc-client-ts Oct 31, 2025
Copilot AI requested a review from dopry October 31, 2025 14:43
Copy link
Owner

@dopry dopry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot why was resolve replaced with nodeResolve?

Copy link
Contributor Author

Copilot AI commented Oct 31, 2025

@copilot why was resolve replaced with nodeResolve?

The old rollup-plugin-node-resolve (v5.2.0) couldn't handle the modern package.json exports field used by oidc-client-ts, which caused build errors.

The newer @rollup/plugin-node-resolve (v11.2.0) - which was already in your devDependencies - properly supports ESM module resolution and the exports field. This allowed the build to successfully resolve the ESM version of oidc-client-ts instead of failing on the UMD version.

The change was necessary to make the migration work, and it uses a package that was already available in the project.

Copilot AI requested a review from dopry October 31, 2025 14:48
@dopry
Copy link
Owner

dopry commented Oct 31, 2025

@copilot please rebase this branch on next and update the PR to target next.

Copy link
Contributor Author

Copilot AI commented Oct 31, 2025

@copilot please rebase this branch on next and update the PR to target next.

Rebased on next branch successfully. Resolved merge conflicts with the existing rollup plugin updates in next (commit 3454ba0). All builds pass. The branch is ready but needs a force push to update the PR - I cannot perform force pushes directly.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • download.cypress.io
    • Triggering command: node index.js --exec install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@dopry dopry force-pushed the copilot/refactor-oidc-client-replacement branch 3 times, most recently from 16ecfd7 to 25caeb5 Compare October 31, 2025 18:07
@dopry dopry force-pushed the copilot/refactor-oidc-client-replacement branch from 25caeb5 to f697ab5 Compare October 31, 2025 18:08
@dopry dopry changed the base branch from main to next October 31, 2025 18:11
@dopry dopry marked this pull request as ready for review October 31, 2025 18:11
@dopry dopry merged commit d8c621f into next Oct 31, 2025
1 check passed
@dopry dopry deleted the copilot/refactor-oidc-client-replacement branch October 31, 2025 18:11
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-next.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: replace oidc-client with oidc-client-ts

2 participants