refactor: update to sveltkit style paths #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is where these would be if this were a sveltekit/vite project that was started at the time of this commit. This is prep for potentially switching from rollup builds to svelte. to stay inside the svelte ecosystem.
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the project structure by moving components from src/components/components.module.js to src/lib/index.js, and adds new button components and an event log component for OIDC authentication functionality.
Key changes:
- Moved library exports from
src/components/components.module.jstosrc/lib/index.js - Added three new button components:
LoginButton,LogoutButton, andRefreshTokenButton - Added an
EventLogcomponent for tracking OIDC events - Updated configuration files to point to the new library location
Reviewed Changes
Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/index.js | New library entry point exporting all OIDC components and utilities |
| src/lib/RefreshTokenButton.svelte | New button component for refreshing authentication tokens |
| src/lib/OidcContext.svelte | Fixed trailing whitespace in JSDoc comments |
| src/lib/LogoutButton.svelte | New button component for logging out users |
| src/lib/LoginButton.svelte | New button component for logging in users |
| src/lib/EventLog.svelte | New component for displaying OIDC event logs with incomplete statement on line 36 |
| src/App.svelte | Updated import path to use new library location |
| rollup.config.js | Updated build input path to new library location |
| package.json | Updated Svelte entry point to new library location |
|
🎉 This PR is included in version 1.2.0-next.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is where these would be if this were a sveltekit/vite project that was started at the time of this commit. This is prep for potentially switching from rollup builds to svelte. to stay inside the svelte ecosystem.