Skip to content

Conversation

@dopry
Copy link
Owner

@dopry dopry commented Nov 2, 2025

@dopry dopry requested a review from Copilot November 2, 2025 01:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates dependencies and adds PostCSS processing capabilities to the project. The main changes include upgrading svelte-highlight from v0.7.1 to v7.9.0 (a major version jump), adding rollup-plugin-postcss for CSS processing, and removing the deprecated lint-staged configuration from package.json.

Key changes:

  • Addition of PostCSS support with autoprefixer in the Rollup build configuration
  • Major version upgrade of svelte-highlight (0.7.1 → 7.9.0)
  • Addition of rollup-plugin-postcss dependency
  • Removal of lint-staged configuration block

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
rollup.config.showcase.js Added rollup-plugin-postcss import and configuration for CSS extraction and minification, plus autoprefixer in svelte-preprocess
package.json Added [email protected], upgraded svelte-highlight to 7.9.0, removed lint-staged configuration
package-lock.json Updated lockfile with new dependencies for postcss plugins and svelte-highlight upgrade

@dopry dopry force-pushed the chore/update-highlight branch from 9d89f91 to 1e86f0b Compare November 2, 2025 01:40
@dopry dopry requested a review from Copilot November 2, 2025 01:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

@dopry dopry force-pushed the chore/update-highlight branch from 1e86f0b to 1dfab65 Compare November 2, 2025 02:00
@dopry dopry requested a review from Copilot November 2, 2025 02:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

@@ -1,7 +1,9 @@
import { nodeResolve } from '@rollup/plugin-node-resolve';
import replace from '@rollup/plugin-replace';
import autoprefixer from 'autoprefixer';
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The autoprefixer import is added but not listed as a dependency in package.json. While it may be included as a transitive dependency through other packages, it's a best practice to explicitly list packages that are directly imported in the project's package.json devDependencies to ensure version control and avoid potential breakage if transitive dependencies change.

Copilot uses AI. Check for mistakes.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is a dep already.

@dopry dopry merged commit c18763e into next Nov 2, 2025
7 checks passed
@dopry dopry deleted the chore/update-highlight branch November 2, 2025 02:09
@github-actions
Copy link

github-actions bot commented Nov 2, 2025

🎉 This PR is included in version 1.2.0-next.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Nov 2, 2025

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants