fix: auth0 logout #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Auth0 logout functionality that was broken after the oidc-client-ts upgrade. The changes update error message checking and replace private property access with the public API.
- Updates error message capitalization to match the current library output
- Replaces deprecated private property access (
_settings._authority,_settings._client_id) with public API (settings.authority,settings.client_id)
dopry
force-pushed
the
fix/auth0-logout
branch
from
12287ae to
1dc9394
Compare
dopry
force-pushed
the
fix/auth0-logout
branch
from
1dc9394 to
a245c60
Compare
dopry
force-pushed
the
fix/auth0-logout
branch
from
a245c60 to
582af41
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (2)
src/lib/OidcContext.svelte:1
- The
preserveRouteandcallback_urlparameters lack type annotations. Add: booleanforpreserveRouteand: string | nullforcallback_urlto maintain consistency with the TypeScript migration.
<script context="module" lang="ts">
src/lib/OidcContext.svelte:1
- The variable rename from
appStatetostatemay be incorrect. The oidc-client-ts library'ssigninRedirectmethod typically expects a parameter namedstatefor the OAuth state parameter, not application state. The application-specific routing data (pathname, search) should likely be passed in a different parameter such asstate(the actual OAuth state string). Review the oidc-client-ts API documentation to ensure the correct parameter structure is being used.
<script context="module" lang="ts">
c5fabd4 to
92f4cd0
Compare
this was broken in the oidc-client-ts upgrade.
dopry
force-pushed
the
fix/auth0-logout
branch
from
92f4cd0 to
61938fb
Compare
|
🎉 This PR is included in version 1.2.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was broken in the oidc-client-ts upgrade.