chore: use playwright container to save time installing deps #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes CI performance by using a pre-configured Playwright container image that includes browser dependencies, eliminating the need for installation time during workflow execution.
- Adds the official Microsoft Playwright container (v1.56.1-noble) to the GitHub Actions workflow
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:52
- The 'playwright install chromium --with-deps' step is now redundant since the Playwright container (line 26) already includes pre-installed browsers and dependencies. This step should be removed to improve CI performance and avoid unnecessary installation time.
- name: playwright install, required for e2e tests
run: npx playwright install chromium --with-deps
dopry
force-pushed
the
chore/streamline-playwright-install
branch
from
5a96322 to
61fa59f
Compare
|
🎉 This PR is included in version 1.2.0-next.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.