Use GitHub Actions for package releases #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oric into useGitHubActions # Conflicts: # .github/workflows/release-cmn.yml
…rsion to the one in local environment
4D42
reviewed
Oct 30, 2025
.github/workflows/release-s2p.yml
Outdated
| shell: cmd | ||
| run: | | ||
| venv\Scripts\python -m pip install --upgrade pip | ||
| venv\Scripts\pip install --constraint Deploy\constraints\pins.txt h5py pyinstaller suite2p |
Collaborator
There was a problem hiding this comment.
Need to be suite2p==0.14.4
Because of this PR: MouseLand/suite2p@be8830d#diff-201e3e4b116e5c43900968776b7d6c708708c22c8436c8e5488b48327f212fd6R181
Someone is doing a PR to fix that problem MouseLand/suite2p#1195
4D42
reviewed
Oct 31, 2025
Deploy/pack_minian.spec
Outdated
Comment on lines
39
to
59
| for dyn_pkg, dest in [ | ||
| ('llvmlite', os.path.join('Library', 'bin')), | ||
| ('scipy', os.path.join('scipy', '.libs')), | ||
| ('h5py', '.'), | ||
| ('SimpleITK', '.'), | ||
| ('cv2', '.'), | ||
| ]: | ||
| try: | ||
| binaries += collect_dynamic_libs(dyn_pkg, destdir=dest) | ||
| except ImportError: | ||
| pass | ||
|
|
||
| conda_prefix = os.environ.get('MINIAN_CONDA_PREFIX') or os.environ.get('CONDA_PREFIX') | ||
| if conda_prefix: | ||
| library_bin = Path(conda_prefix) / 'Library' / 'bin' | ||
| if library_bin.is_dir(): | ||
| dll_patterns = [ | ||
| 'hdf*.dll', | ||
| 'hdf5*.dll', | ||
| ] | ||
| seen = set() |
Collaborator
There was a problem hiding this comment.
If I comments the hdf5 stuff like that
for dyn_pkg, dest in [
('llvmlite', os.path.join('Library', 'bin')),
('scipy', os.path.join('scipy', '.libs')),
# ('h5py', '.'),
('SimpleITK', '.'),
('cv2', '.'),
]:
try:
binaries += collect_dynamic_libs(dyn_pkg, destdir=dest)
except ImportError:
pass
conda_prefix = os.environ.get('MINIAN_CONDA_PREFIX') or os.environ.get('CONDA_PREFIX')
if conda_prefix:
library_bin = Path(conda_prefix) / 'Library' / 'bin'
if library_bin.is_dir():
dll_patterns = [
# 'hdf*.dll',
# 'hdf5*.dll',
]
seen = set()Everything work. I don't have the hdf5 error anymore
Collaborator
Author
There was a problem hiding this comment.
It works with Github Actions?
Collaborator
There was a problem hiding this comment.
I can't test the Github actions. Some how I don't have the right to edit this file and push it :(
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See builds here: https://github.com/doriclenses/pyDoric/actions
See releases here: https://github.com/doriclenses/pyDoric/releases