add support for karma-junit-reporter #684
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyoung-tf
force-pushed
the
karma-junit-reporter-support
branch
from
42773c6 to
e96f14b
Compare
gyoung-tf
force-pushed
the
karma-junit-reporter-support
branch
from
e96f14b to
08646e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for karma-junit-reporter.
The only difference between Jest Junit and Karma Junit Reporter is that Jest comes with a parent
<testsuites>XML element wrapper, whereas Karma Junit reporter does not. So this PR essentially duplicates the Jest Junit parser intokarma-junitparser. Any suggestions/feedback on how to deduplicate things is appreciated. Originally had the karma parser extending the Jest parser, but that caused some problems with types that could only be fixed with@ts-ignore.