Skip to content

Add safety cap to ComicVine issue pagination #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dotMavriQ wants to merge 1 commit into from
Closed

Add safety cap to ComicVine issue pagination #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/Services/ComicVineService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ public function fetchVolumeIssues(string $volumeId): array
$allIssues = [];
$offset = 0;
$limit = 100;
$maxPages = 10; // Safety cap to avoid exceeding execution time limits
$page = 0;

try {
do {
Expand Down Expand Up @@ -149,12 +151,13 @@ public function fetchVolumeIssues(string $volumeId): array
}

$offset += $limit;
$page++;

// Respect rate limits if we need more pages
if ($offset < $totalResults && ! empty($results)) {
usleep(400000);
}
} while ($offset < $totalResults && ! empty($results));
} while ($offset < $totalResults && ! empty($results) && $page < $maxPages);
} catch (\Exception) {
// Return whatever we collected so far
}
Expand Down
Loading