reworked transform serialization #25
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: magnonellie <[email protected]>
This updates the minimum `nalgebra` version to `0.16.7` as that version contains the necessary code update. Related amethyst#1066
Author
|
I just realized that if format compatibility with the cgmath representation is the goal, that the serialization routine should reorder the |
dotellie
force-pushed
the
nalgebra
branch
2 times, most recently
from
2a0919c to
0665452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tooling around with your branch so I could keep ahead of the changes when it gets merged, and I found a small bug in the
rotationcomponent ofTransformdeserialization - for whatever reason the quaternion representation differs from the construction order, so thewelement ended up in the wrong spot. I ended up writing some tests for the serialization and reworking it to be more idiomatically serde, and I figured I'd send you the PR in case you want to incorporate it.It might be smarter to tie the
SerializedTransformstructDefaultimpl to theTransformimpl, but I wasn't sure of the best way to do it.