🪲 BUG-#82: Fix backoff mutating retry_delay permanently across calls - #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
current_delayinstead of mutatingself.retry_delayduring backofftest_backoff_does_not_mutate_retry_delayto verifyretry_delayis preserved after retriesMotivation and Context
When
@action(retry=N, backoff=True)is used, the exponential backoff logic modifiesself.retry_delayin place. Since theActioninstance is shared across all calls, subsequent calls start with the last doubled delay instead of the original value.Closes #82
Types of changes
Checklist