Skip to content

🪲 BUG-#130: Fix mutable default arguments in Config.__init__ causing shared state #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FernandoCelmer merged 3 commits into from
Apr 7, 2026
Merged

🪲 BUG-#130: Fix mutable default arguments in Config.__init__ causing shared state #150

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e773289
🪲 BUG-#130: Fix mutable default arguments in Config.__init__ causing …
FernandoCelmer Apr 6, 2026
90c5cd6
🪲 BUG-#130: Use explicit None check instead of or to preserve falsy p…
FernandoCelmer Apr 6, 2026
aa992b2
📝 PEP8-#130: Fix ruff format line length
FernandoCelmer Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions dotflow/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,17 +61,19 @@ class Config:

def __init__(
self,
storage: Storage | None = StorageDefault(),
notify: Notify | None = NotifyDefault(),
log: Log | None = LogDefault(),
api: Api | None = ApiDefault(),
scheduler: Scheduler | None = SchedulerDefault(),
storage: Storage | None = None,
notify: Notify | None = None,
log: Log | None = None,
api: Api | None = None,
scheduler: Scheduler | None = None,
) -> None:
self.storage = storage
self.notify = notify
self.log = log
self.api = api
self.scheduler = scheduler
self.storage = storage if storage is not None else StorageDefault()
self.notify = notify if notify is not None else NotifyDefault()
self.log = log if log is not None else LogDefault()
self.api = api if api is not None else ApiDefault()
self.scheduler = (
scheduler if scheduler is not None else SchedulerDefault()
)

self._validate()

Expand Down
Loading