🪲 BUG-#129: Fix task_id=0 being treated as falsy and overwritten with None - #151
Merged
Conversation
FernandoCelmer
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
task_idsetter to only acceptintvalues, removing the unsafe fallback that treated0as falsyMotivation and Context
The original setter used
if not self.task_id:which evaluatednot 0asTrue, causingtask_id=0(the first task in every workflow) to be vulnerable to overwrite withNone. The fix removes the fallback entirely — onlyisinstance(value, int)is checked, ensuring type safety and correct handling oftask_id=0.Closes #129
Types of changes
Checklist