🪲 BUG-#128: Fix Background mode blocking by removing immediate thread.join() - #152
Merged
Conversation
…ion before assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
thread.join(), use daemon thread, store thread reference asself.threadself.tasksinstead of emptyself.queueto avoid race condition_callback_workflowfor background mode since tasks have not completed yetprocess.threadon Manager instance for optional explicit joinMotivation and Context
Background mode called
thread.join()immediately afterthread.start(), making it identical to sequential mode. Additionally,get_tasks()returned the empty queue (populated asynchronously by the thread), and_callback_workflowfired before any task had run. The fix ensures background mode is truly non-blocking while maintaining access to task objects and thread control.Closes #128
Types of changes
Checklist