fix: replace self-chaining exception raise with 'from None' in retry loop - #157
Merged
FernandoCelmer merged 1 commit intoApr 7, 2026
Conversation
…loop Fixes dotflow-io#132 — raising 'last_exception from last_exception' created a circular __cause__ reference on the exception object. Using 'from None' cleanly suppresses the implicit context at the final retry attempt.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
raise last_exception from last_exceptionwithraise last_exception from Noneto fix circular exception chaining__cause__is not self-referential after retries are exhaustedMotivation and Context
The self-chaining exception (
from last_exception) was introduced by a ruff B904 auto-fix. It sets__cause__to the same object, producing confusing tracebacks.from Nonesuppresses the implicit context while preserving the full original stack trace.Closes #132
Types of changes
Checklist