Skip to content

🪲 BUG-#131: Fix timeout thread leak in ThreadPoolExecutor #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FernandoCelmer merged 3 commits into from
Apr 7, 2026
Merged

🪲 BUG-#131: Fix timeout thread leak in ThreadPoolExecutor #166

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7bd3ef4
🪲 BUG-#131: Fix timeout thread leak by using shutdown(wait=False, can…
FernandoCelmer Apr 7, 2026
4898957
🪲 BUG-#131: Prevent thread pileup by not retrying on TimeoutError
FernandoCelmer Apr 7, 2026
67587ad
🪲 BUG-#131: Shutdown executor on task exception to prevent resource leak
FernandoCelmer Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion dotflow/core/action.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,19 +144,32 @@ def _run_action(self, *args, task=None, **kwargs):
for attempt in range(1, self.retry + 1):
try:
if self.timeout:
with ThreadPoolExecutor(max_workers=1) as executor:
executor = ThreadPoolExecutor(max_workers=1)
try:
future = executor.submit(
self._call_func,
is_async,
*args,
**kwargs,
)
result = future.result(timeout=self.timeout)
except TimeoutError:
future.cancel()
executor.shutdown(wait=False, cancel_futures=True)
raise
except Exception:
executor.shutdown(wait=False)
raise
else:
executor.shutdown(wait=False)
else:
result = self._call_func(is_async, *args, **kwargs)

return result

except TimeoutError:
raise

except Exception as error:
last_exception = error

Expand Down
Loading