🪲 BUG-#140: Fix race condition, thread tracking, and signal handler restoration in SchedulerCron - #168
Closed
FernandoCelmer wants to merge 3 commits into
Closed
🪲 BUG-#140: Fix race condition, thread tracking, and signal handler restoration in SchedulerCron#168FernandoCelmer wants to merge 3 commits into
FernandoCelmer wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dotflow/providers/scheduler_cron.py— Three fixes for SchedulerCronFix 1 — Race condition in queue overlap (#140)
Move thread creation decision inside the lock in
_execute_queued. The thread object is created under the lock and started after release, closing the window where_dispatch_queuecould modify_queue_count.Fix 2 — Daemon threads never joined (#142)
Track all spawned threads in
_threadslist.stop()now joins all in-flight threads with an optional timeout before returning.Fix 3 — Signal handlers overwritten globally (#144)
Save previous SIGINT/SIGTERM handlers in
_register_signals. Restore them in_restore_signalscalled fromstop().Closes #140
Closes #142
Closes #144
Types of changes
Checklist