🪲 BUG-#143: Fix retry=0 causing zero execution attempts

dotflow/core/action.py

@@ -141,7 +141,9 @@ def _run_action(self, *args, task=None, **kwargs):
 
         is_async = asyncio.iscoroutinefunction(self.func)
 
-        for attempt in range(1, self.retry + 1):
+        max_attempts = max(1, self.retry)
+
+        for attempt in range(1, max_attempts + 1):
             try:
                 if self.timeout:
                     executor = ThreadPoolExecutor(max_workers=1)
@@ -178,7 +180,7 @@ def _run_action(self, *args, task=None, **kwargs):
                 ):
                     raise ExecutionWithClassError() from None
 
-                if attempt == self.retry:
+                if attempt == max_attempts:
                     raise last_exception from None
 
                 if task is not None:

tests/core/test_action.py

@@ -62,6 +62,29 @@ def test_instantiating_action_class_with_fail_retry(self):
             for record in self._caplog.records:
                 self.assertEqual(record.message, error_message)
 
+    def test_retry_zero_still_executes_task_once(self):
+        call_count = {"n": 0}
+
+        def counting_step():
+            call_count["n"] += 1
+
+        inside = Action(counting_step, retry=0)
+        inside(task=self.task)
+
+        self.assertEqual(
+            call_count["n"],
+            1,
+            "retry=0 should execute the task exactly once, not zero times",
+        )
+
+    def test_retry_zero_raises_on_failure(self):
+        def always_fail():
+            raise ValueError("fail")
+
+        inside = Action(always_fail, retry=0)
+        with self.assertRaises(ValueError):
+            inside(task=self.task)
+
     def test_sets_retry_status_before_retrying(self):
         calls = {"count": 0}
         statuses = []