v125.0.2 #46
Open
v125.0.2 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it can be rolled out incrementally. Original Revision: https://phabricator.services.mozilla.com/D240630 Differential Revision: https://phabricator.services.mozilla.com/D240722
…r a=dmeehan Original Revision: https://phabricator.services.mozilla.com/D239965 Differential Revision: https://phabricator.services.mozilla.com/D239996
…meehan Back these two patches out from beta because of a regression. Differential Revision: https://phabricator.services.mozilla.com/D240000
…Glean on shutdown a=dmeehan Only once the user interacted with the telemetry reporting policy modal we can be sure that the preference for collection is valid. If it's not we don't initialize Glean and thus don't collect any data. Original Revision: https://phabricator.services.mozilla.com/D239753 Differential Revision: https://phabricator.services.mozilla.com/D240129
…`mPresContext` to the result of `Event::GetScreenCoords` a=dmeehan The result of `Event::GetScreenCoords()` is already applied the scale of `mPresContext` [1]. Therefore, we should not apply it again in `DuplicatePrivateData()` [2][3]. Note that before bug 1931692, it was always multiplied by `CSSToLayoutDeviceScale(1)` perhaps accidentally because it tries to refer `mPresContext`, but it's already cleared by `Event::DuplicatePrivateData()` [4]. Therefore, it always used the fallback value. 1. https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/dom/events/Event.cpp#649,652 2. https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/dom/events/UIEvent.cpp#174 3. https://searchfox.org/mozilla-central/rev/fcfb558f8946f3648d962576125af46bf6e2910a/dom/events/MouseEvent.cpp#215 4. https://hg.mozilla.org/mozilla-central/log/bac619a7d667291a7f6e9496f3406e8ed15dec24/dom/events/UIEvent.cpp Original Revision: https://phabricator.services.mozilla.com/D239477 Differential Revision: https://phabricator.services.mozilla.com/D239862
…meehan Now why did this cause problems? Fenix registers pings in Kotlin code, which calls back into Glean. Glean stores the registered instance in an internal hashmap for later lookup. These instances carry around state (whether they are enabled or not), which `setEnabled` changes. Now eventually `Services.fog.registerCustomPings()` is called in geckoview.js, which re-registers all pings (because it wasn't limited to a subset based on the app ID). This overwrites the stored instances in the Glean-internal hashmap and thus also the state. So later when looking up whether a ping is enabled and Glean should store data for a ping it checks the now-latest instance and that's a different one from the one `setEnabled` was called on in Fenix. The `usage-reporting` ping was thus always marked as disabled in this scenario. Why did it work in simple testing? Because Gecko never launched! A quick open & background of Fenix doesn't even start Gecko and thus never calls `registerCustomPings` and everything works. Most users however do have tabs open and thus Gecko is launched and the pings will lack the data. This is hard to write a proper test for. Eventually we should have a Fenix instrumentation test ensuring the ping is sent with valid data after tabs have been opened. Differential Revision: https://phabricator.services.mozilla.com/D240130
…p in CalculateBoundingCompositionSize. a=dmeehan Before this change, we had used the in-process root pres shell to calculate the root composition bounds, thus if the browser window is quite small but a popup window is larger than the browser window, the popup window's composition size was limited to the browser window composition bounds. Original Revision: https://phabricator.services.mozilla.com/D238554 Differential Revision: https://phabricator.services.mozilla.com/D239236
…in RestrictToRootDisplayPort. a=dmeehan This change is similar to the previous change, but for displayport. Original Revision: https://phabricator.services.mozilla.com/D238555 Differential Revision: https://phabricator.services.mozilla.com/D239237
…X-ANDROID_136_0_1_BUILD1 a=release CLOSED TREE DONTBUILD
…X_136_0_1_BUILD1 a=release CLOSED TREE DONTBUILD
…=dmeehan I missed this one in bug 1427715. Differential Revision: https://phabricator.services.mozilla.com/D240978
…X_136_0_1_RELEASE a=release CLOSED TREE DONTBUILD
…X-ANDROID_136_0_1_RELEASE a=release CLOSED TREE DONTBUILD
For consistency with the unchecked state. Differential Revision: https://phabricator.services.mozilla.com/D241043
…s,aosmond, a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D240422
…meehan Differential Revision: https://phabricator.services.mozilla.com/D241212
…5. r=Julian, a=dmeehan And add a comment pointing to this and related bugs. Differential Revision: https://phabricator.services.mozilla.com/D240979
…s - a=dmeehan Differential Revision: https://phabricator.services.mozilla.com/D241347
… first impression AND seen more than 20 times for Beta r=adw a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D241503
…ted with for the back-button intervention. r=farre,dom-core,media-playback-reviewers,alwu a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D239470
…=pascalc Differential Revision: https://phabricator.services.mozilla.com/D241527
…X_137_0b6_BUILD1 a=release CLOSED TREE DONTBUILD
…TION_137_0b6_BUILD1 a=release CLOSED TREE DONTBUILD
…TION_137_0b6_RELEASE a=release CLOSED TREE DONTBUILD
…X-ANDROID_137_0b6_RELEASE a=release CLOSED TREE DONTBUILD
…ile dialog, a=pascalc Original Revision: https://phabricator.services.mozilla.com/D244568 Differential Revision: https://phabricator.services.mozilla.com/D244572
…X_137_0_1_BUILD1 a=release CLOSED TREE DONTBUILD
…X_137_0_1_RELEASE a=release CLOSED TREE DONTBUILD
…dshin a=pascalc The caption box is relatively positioned which means it z-sorts against the controls. And it is after the controls in the DOM, so before we were just being lucky. While at it, add a missing :-moz-native-anonymous to the selector, so we don't select content nodes (doesn't matter much, wouldn't be displayed anyways). Long term we should probably move the caption box to the controls. The only reason we don't do that is because we didn't have the setup to make ::cue work properly, but now we do. Differential Revision: https://phabricator.services.mozilla.com/D244826
…update r=Standard8,jcristau a=pascalc This will avoid `arc diff` hanging if untracked files are around. I've taken this approach rather than using `arc diff --allow-untracked` to avoid accidentally missing newly added files from other periodic updates. Differential Revision: https://phabricator.services.mozilla.com/D245078
…ascalc Apparently, Windows can happily display your window half-painted, even though you're between ::BeginPaint() and ::EndPaint(). For accelerated windows it doesn't really matter because we use DWM for the window contents, but for unbuffered windows like tooltips it does. This is the minimal patch for uplift, more cleanups incoming. Original Revision: https://phabricator.services.mozilla.com/D244524 Differential Revision: https://phabricator.services.mozilla.com/D245092
…reviewers,nchevobbe a=pascalc Turns out my first version of D238048 was actually correct. We seem to get "command" events even for commands not defined in <commandset id="sourceEditorCommands">. Differential Revision: https://phabricator.services.mozilla.com/D242692
…layback-reviewers,aosmond a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D245157
…nux/Mac/MSIX a=pascalc Enable on-train rollout of TOS modal experience for 25% of users on Linux, Mac, and MSIX. For uplift into 137 release if metrics from [[ https://experimenter.services.mozilla.com/nimbus/new-onboarding-experience-experiment-phase-1-windows/summary | initial Windows experiment ]] are deemed acceptable. Original Revision: https://phabricator.services.mozilla.com/D242584 Differential Revision: https://phabricator.services.mozilla.com/D243685
…ening file picker r=joschmidt,mtigley a=pascalc Original Revision: https://phabricator.services.mozilla.com/D243062 Differential Revision: https://phabricator.services.mozilla.com/D243411
…shel a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D245015
…ture modal with HCM in 137 a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D244554
…nature in pdf.js in 137 a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D244553
…s - a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D245120
…ons work again; r=smaug a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D244320
Original Revision: https://phabricator.services.mozilla.com/D244884 Differential Revision: https://phabricator.services.mozilla.com/D245238
Original Revision: https://phabricator.services.mozilla.com/D243146 Differential Revision: https://phabricator.services.mozilla.com/D243626
…k-reviewers,jolin a=pascalc In H265::CompareExtraData(), SPSIterator::IsValid() is used as a boolean expression to determine whether two SPS NALUs should be compared. If it returns an incorrect result, it can lead to a false detection of a configuration change, causing decoded frames to be discarded. Differential Revision: https://phabricator.services.mozilla.com/D243528
…h the XSLTProcessor DOM API. a=pascalc Original Revision: https://phabricator.services.mozilla.com/D241227 Differential Revision: https://phabricator.services.mozilla.com/D244759
…es were fixed in a better way in bug 1953525, a=pascalc Original Revision: https://phabricator.services.mozilla.com/D244250 Differential Revision: https://phabricator.services.mozilla.com/D244762
…s - a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D245384
…X_137_0_2_BUILD1 a=release CLOSED TREE DONTBUILD
…X-ANDROID_137_0_2_BUILD1 a=release CLOSED TREE DONTBUILD
…X-ANDROID_137_0_2_RELEASE a=release CLOSED TREE DONTBUILD
…X_137_0_2_RELEASE a=release CLOSED TREE DONTBUILD
…s - a=pascalc Differential Revision: https://phabricator.services.mozilla.com/D245866
…allow for all types of add-on id. r=search-reviewers,scunnane, a=dsmith Differential Revision: https://phabricator.services.mozilla.com/D245105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firefox v125.0.2
Merge in changes from upstream (v125.0.2)
Checklist
REVISIONfile is ready to be updated