Skip to content

Conversation

@walterlv
Copy link
Member

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for redirecting console logger output to standard error (stderr) stream, providing more flexibility for log output configuration. The PR also improves code documentation and modernizes parameter types.

  • Introduces LoggerConsoleOutputTo enum to control whether logs write to stdout or stderr
  • Adds WithOutput() method to ConsoleLoggerBuilder for configuring output destination
  • Improves parameter types by changing from string[] to IReadOnlyList<string> for better API design

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/DotNetCampus.Logger/Writers/ConsoleLogger.cs Implements stderr support by adding OutputTo property and modifying output stream selection logic; converts SafeWriteLine from static to instance method; adds lazy initialization for output writer
src/DotNetCampus.Logger/Writers/ConsoleLoggerBuilder.cs Adds WithOutput() method for configuring console output destination; refactors internal state management to support new OutputTo feature; improves documentation comments
src/DotNetCampus.Logger/Writers/Helpers/TagFilterManager.cs Updates method signatures to use IReadOnlyList<string> instead of string[] for better API design
src/DotNetCampus.Logger/LoggerBuilder.cs Adds comprehensive XML documentation comments for all public methods
src/DotNetCampus.Logger/DotNetCampus.Logger.csproj Removes debug-mode suppression of documentation warnings (CS1591) to enforce documentation completeness
src/DotNetCampus.Logger/Writers/TraceLogger.g.cs Adds <inheritdoc /> documentation comment to IsEnabled method
src/DotNetCampus.Logger/Writers/DebugLogger.g.cs Adds <inheritdoc /> documentation comment to IsEnabled method
src/DotNetCampus.Logger/CompositeLogger.cs Adds <inheritdoc /> documentation comments to IsEnabled and Log methods

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lindexi lindexi merged commit 7a51cb5 into main Nov 27, 2025
9 checks passed
@lindexi lindexi deleted the t/walterlv/stderr branch November 27, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants