Fundamentals overview article overhaul - #37568
Conversation
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
wadepickett
left a comment
There was a problem hiding this comment.
@guardrex: Approved. I think it is better. Well done. Outside of this immediate PR we should have a good lively discussion on the pro-cons and "when if'"s of moving compilable code examples to non-compilable snapsots on any large scale of overhalls so we have some consistant direction with the outcome we want.
|
I agree. Let's take it up next week while still working on this PR. We'll probably come up with some improvements to this. |
This PR is fine (unless the scope for some reason increases ), but for outside of this PR's scope good to figure out more generally what other types of content fit the move to uncompiled snapshot files and what doesn't, and when at least one clean compilable working example is warrented even when using snapshots. @tdykstra just for CC as we think about this going forward. |
|
@guardrex: This PR is approved and can be squashed and merged. |
Fixes #37558
Addresses #34356
Internal previews
Build report