passed args to benchmark runner

[chan18]

fixes #1290

[dnfclas]

All CLA requirements met.

[chan18]

did not wrote test cases yet, need a review from @adamsitnik,

[adamsitnik]

Thank you @chan18 ! The PR looks very promising, please take a look at my comments and address them.

[chan18]

@adamsitnik

[adamsitnik]

Looks good to me!

Could you please add the public static Summary[] Run(Assembly assembly, IConfig config = null,string[] args = null) overload and fix the formatting issues?

[chan18]

BenchmarkDotNet/src/BenchmarkDotNet/Running/BenchmarkRunnerDirty.cs

Lines 82 to 118 in 5589986

	var logger = config.GetNonNullCompositeLogger();
	var userInteraction = new UserInteraction();
	var (isParsingSuccess, parsedConfig, options) = ConfigParser.Parse(args, logger, config);
	if (!isParsingSuccess) // invalid console args, the ConfigParser printed the error
	return null;
	if (options.PrintInformation)
	{
	logger.WriteLine(HostEnvironmentInfo.GetInformation());
	return null;
	}
	var effectiveConfig = ManualConfig.Union(config, parsedConfig);
	var types = new List<Type>();
	types.Add(type);
	var (allTypesValid, allAvailableTypesWithRunnableBenchmarks) = TypeFilter.GetTypesWithRunnableBenchmarks(types, new List<Assembly>(), logger);
	if (!allTypesValid) // there were some invalid and TypeFilter printed errors
	return null;
	if (allAvailableTypesWithRunnableBenchmarks.IsEmpty())
	{
	userInteraction.PrintNoBenchmarksError(logger);
	return null;
	}
	if (options.ListBenchmarkCaseMode != ListBenchmarkCaseMode.Disabled)
	{
	BenchmarkCasesPrinter.PrintList(logger, effectiveConfig, allAvailableTypesWithRunnableBenchmarks, options);
	return null;
	}
	var benchmarks = options.UserProvidedFilters
	? TypeFilter.Filter(effectiveConfig, allAvailableTypesWithRunnableBenchmarks)
	: new BenchmarkRunInfo[] { BenchmarkConverter.TypeToBenchmarks(type, config) };
	return BenchmarkRunnerClean.Run(benchmarks).Single();

needs another overload. I am thinking to create another function to move the code that parses args and use it in two different functions, Something like this in below.

RunWithDirtyAssemblyResolveHelper(Type type, IConfig config, string[] args)

RunWithDirtyAssemblyResolveHelper(Assembly assembly, IConfig config = null,string[] args) 

@adamsitnik

[chan18]

hi, @adamsitnik please review it. Let me know any other changes or improvements you want to make!

[adamsitnik]

Hi @chan18

Thank you for your hard work! Please take a look at my comments.

Adam

[adamsitnik]

The build fails with following compilation error:

Running/BenchmarkRunnerDirty.cs(88,16): error CS0029: Cannot implicitly convert type 'BenchmarkDotNet.Reports.Summary[]' to 'BenchmarkDotNet.Reports.Summary'

Could you please fix it?

[chan18]

Fixed it, Can you please check. let me know if you have anyother change that i need to make.