[xamarin] fix Mono runtime version detection #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://github.com/mono/mono/blob/0a37eeadece5c2cec8a6e1f43a94f0b323a22513/mcs/class/corlib/Mono/Runtime.cs#L68-L73 `Mono.Runtime.GetDisplayName` is `public` on Xamarin platforms, and so we need to include `BindingFlags.Public` to call it via reflection. I updated the screenshot in the documentation to reflect what the value looks like running on Xamarin.Android in VS 2019 16.5. I also took an attempt at fixing the documentation for Xamarin, I think the link is just missing. Hopefully this URL will work now: https://benchmarkdotnet.org/articles/samples/IntroXamarin.html
|
/cc @adamsitnik |
adamsitnik
approved these changes
Apr 20, 2020
There was a problem hiding this comment.
LGTM, @jonathanpeppers thank you for providing the fix and explanation!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://github.com/mono/mono/blob/0a37eeadece5c2cec8a6e1f43a94f0b323a22513/mcs/class/corlib/Mono/Runtime.cs#L68-L73
Mono.Runtime.GetDisplayNameispublicon Xamarin platforms, and sowe need to include
BindingFlags.Publicto call it via reflection.I updated the screenshot in the documentation to reflect what the
value looks like running on Xamarin.Android in VS 2019 16.5.
I also took an attempt at fixing the documentation for Xamarin, I
think the link is just missing. Hopefully this URL will work now: