Skip to content

[samples] UI tweaks to Xamarin samples #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

jonathanpeppers
Copy link
Member

These are just general UI improvements to the sample. Which is still admittedly, a bit ugly.

  • Use a Padding for the entire page on iOS, to accomodate an iOS device/simulator with the "notch".
  • Use a valid mono-spaced font on iOS: Courier
  • Use Margin instead of Padding on the "Run" button. The wrong property was used before.

These are just general UI improvements to the sample. Which is still admittedly, a bit ugly.

* Use a `Padding` for the entire page on iOS, to accomodate an iOS device/simulator with the "notch".
* Use a valid mono-spaced font on iOS: `Courier`
* Use `Margin` instead of `Padding` on the "Run" button. The wrong property was used before.
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @jonathanpeppers !

@adamsitnik adamsitnik merged commit d95493b into dotnet:master Apr 28, 2020
@AndreyAkinshin AndreyAkinshin added this to the v0.12.2 milestone Apr 28, 2020
@jonathanpeppers jonathanpeppers deleted the xamarin-samples-ui branch April 28, 2020 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants