Skip to content

Fix wrongly reported os brand string for Windows 10 1909 #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Fix wrongly reported os brand string for Windows 10 1909 #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BenchmarkDotNet/Environments/OsBrandStringHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ public string ToPrettifiedString([CanBeNull] int? ubr)
new Windows10Version(1803, "Redstone 4", "April 2018 Update", 17134),
new Windows10Version(1809, "Redstone 5", "October 2018 Update", 17763),
new Windows10Version(1903, "19H1", "May 2019 Update", 18362),
new Windows10Version(1909, "19H2", "November 2018 Update", 18363),
new Windows10Version(1909, "19H2", "November 2019 Update", 18363),
new Windows10Version(2004, "20H1", "?", 19041)
};

Expand Down
2 changes: 1 addition & 1 deletion tests/BenchmarkDotNet.Tests/Environments/OsBrandStringTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ public void WindowsIsPrettified(string originalVersion, string prettifiedName)
[InlineData("10.0.17134", 48, "Windows 10.0.17134.48 (1803/April2018Update/Redstone4)")]
[InlineData("10.0.17763", 1, "Windows 10.0.17763.1 (1809/October2018Update/Redstone5)")]
[InlineData("10.0.18362", 693, "Windows 10.0.18362.693 (1903/May2019Update/19H1)")]
[InlineData("10.0.18363", 657, "Windows 10.0.18363.657 (1909/November2018Update/19H2)")]
[InlineData("10.0.18363", 657, "Windows 10.0.18363.657 (1909/November2019Update/19H2)")]
[InlineData("10.0.19041", 1, "Windows 10.0.19041.1 (2004/?/20H1)")]
public void WindowsWithUbrIsPrettified(string originalVersion, int ubr, string prettifiedName)
=> Check(OsBrandStringHelper.Prettify("Windows", originalVersion, ubr), prettifiedName);
Expand Down