Skip to content

Don't try to parse blank lines #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 16, 2020
Merged

Don't try to parse blank lines #1458

merged 1 commit into from
May 16, 2020
+3 −2

Conversation

TysonMN
Copy link
Contributor

@TysonMN TysonMN commented May 15, 2020

Fixes #1456

Quoting from #1456 (comment)

If it's annoying to you that the Debug build is throwing so many exceptions please feel free to send a PR with some defensive checks that avoid parsing blank lines.

It does annoy me! :)

This PR filters out blank lines before attempting to parse.

adamsitnik
adamsitnik approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @bender2k14 !

@adamsitnik adamsitnik merged commit ceef311 into dotnet:master May 16, 2020
@TysonMN TysonMN deleted the #1456_dont_parse_blank_lines branch October 18, 2020 01:36
@adamsitnik adamsitnik added this to the v0.13.0 milestone May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamsitnik adamsitnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Measurement.Parse asked to parse blank line
2 participants
@TysonMN @adamsitnik