Skip to content

use Environment.Version to determine .NET 5+ versions #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 30, 2020
Merged

use Environment.Version to determine .NET 5+ versions #1580

merged 1 commit into from
Oct 30, 2020

Conversation

adamsitnik
Copy link
Member

Fixes #1576

I've tested it both with CoreRun from 3.1 dotnet/corefx and 6.0 dotnet/runtime and it works properly now:

dotnet run -c Release -f netcoreapp2.1 --filter IntroArguments --job dry --corerun 
C:\Projects\forks\corefx\artifacts\bin\testhost\netcoreapp-Windows_NT-Release-x64\shared\Microsoft.NETCore.App\3.1.9\CoreRun.exe 
C:\Projects\forks\corefx\artifacts\bin\testhost\netcoreapp-Windows_NT-Release-x64\shared\Microsoft.NETCore.App\copy\CoreRun.exe

obraz

dotnet run -c Release -f netcoreapp2.1 --filter IntroArguments --job dry --corerun
C:\Projects\forks\corefx\artifacts\bin\testhost\netcoreapp-Windows_NT-Release-x64\shared\Microsoft.NETCore.App\3.1.9\CoreRun.exe
C:\Projects\runtime\artifacts\bin\testhost\net5.0-Windows_NT-Release-x64\shared\Microsoft.NETCore.App\6.0.0\CoreRun.exe

obraz

cc @stephentoub

@adamsitnik adamsitnik added this to the v0.13.0 milestone Oct 30, 2020
stephentoub
stephentoub approved these changes Oct 30, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @adamsitnik :)

@AndreyAkinshin AndreyAkinshin merged commit 8b2214b into master Oct 30, 2020
@AndreyAkinshin AndreyAkinshin deleted the 1576 branch October 30, 2020 14:13
@AndreyAkinshin
Copy link
Member

@adamsitnik FYI: our master branch is red now because it's can fetch Cake from myget. It sould be green again as soon as the myget team resolves the issue.
image

http://status.myget.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyAkinshin AndreyAkinshin AndreyAkinshin approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
Area:Toolchains
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging this pull request may close these issues.

Missing/misleading version number with corerun
3 participants
@adamsitnik @AndreyAkinshin @stephentoub