Skip to content

Update message to not suggest an obsolete API #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Update message to not suggest an obsolete API #1590

merged 1 commit into from
Nov 10, 2020

Conversation

martincostello
Copy link
Member

Update the hint for non-optimised references to use the WithOptions(ConfigOptions) method, rather than the obsolete With(ConfigOptions) overload.

Update the hint for non-optimised methods to use the `WithOptions(ConfigOptions)` method, rather than the obsolete `With(ConfigOptions)` overload.
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @martincostello !

@adamsitnik adamsitnik merged commit c63fe84 into dotnet:master Nov 10, 2020
@martincostello martincostello deleted the patch-1 branch November 10, 2020 14:37
@AndreyAkinshin AndreyAkinshin added this to the v0.13.0 milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants